search

untitledkingdom / mina-puma

Puma tasks for Mina
MIT License
84 stars 40 forks source link

Adds `phased_restart:or_start` and `restart:or_start` tasks #20

Open hovancik opened 7 years ago

hovancik commented 7 years ago

rationale

When I deploy app with mina-puma, I want to be able to use one command to restart (or start app if needed). With tasks available right now, it's not possible, so to check whether app is running I would need to bring extra stuff, that is already in mina-puma (eg. :pumactl_socket ), to my deploy.rb.

changes done

pumactl_command was extended to accept one more parameter or_start, which defaults to false, so no changes needs to be done to current code. Whenor_start is set to true, app will be started when not running.

New tasks restart:or_start and phased_restart:or_start were added utilising this functionality.

Please let me know if that's fine, or you can see a better way to do it. Then I can update README and so on.

windy commented 6 years ago

+1

windy commented 5 years ago

@hovancik I refactor it to mina-ng-puma here:

https://github.com/windy/mina-ng-puma

phased_restart and restart need start puma correctly when puma is down.

jmuheim commented 5 years ago

Is this gem still under maintenance? I have invested many hours to make it run, and I find the README could be a bit more exhaustive (e.g. I did not find anything about puma_port setting until I dug into the code itself).

If I add details to the README, would this PR possibly be merged? If not, what about https://github.com/windy/mina-ng-puma, is it still maintained and would embrace PRs?