search

untitledkingdom / mina-puma

Puma tasks for Mina
MIT License
85 stars 40 forks source link

Missing `mina init` in README installation section #24

Closed belgoros closed 3 years ago

belgoros commented 6 years ago

It seems like the command

mina init

is missing in Installation section, - you start the Usage section directly with

Add this to your config/deploy.rb file:

But config/deploy.rb does not exist yet, - you will have to run mina init before to generate it.

d4rky-pl commented 6 years ago

True, we expected people coming to use this gem to have Mina already configured but I can see how can that be confusing to a total newcomer. Feel free to send a PR fixing this :)

belgoros commented 6 years ago

@d4rky-pl I have created https://github.com/sandelius/mina-puma/pull/24

belgoros commented 6 years ago

Is it OK to submit it there ou I have to submit it to untitledkingdom ?

d4rky-pl commented 6 years ago

@belgoros I'm afraid Sandelius didn't give us access to his repository and only added the redirect so you will have to send it here as well :)

belgoros commented 6 years ago

@d4rky-pl I submitted it https://github.com/untitledkingdom/mina-puma/pull/25 and closed this one: https://github.com/sandelius/mina-puma/pull/24

lulalala commented 3 years ago

25 is merged so we can close this?

belgoros commented 3 years ago

Yep sure, thank you 😄