untitledkingdom / mina-puma

Puma tasks for Mina
MIT License
85 stars 40 forks source link

Add puma_rails_path env to support deploying to current's sub directory #6

Closed windy closed 7 years ago

d4rky-pl commented 8 years ago

Hey, for starters - sorry for very long reply and thanks for the contribution!

I like your addition and I see why it could be useful but the name puma_rails_path implies this gem can only be used with Rails (and that's not the case). Could you please rename it to puma_root_path to avoid confusion?

windy commented 7 years ago

@d4rky-pl I have modified the code from puma_rails_path to puma_root_path, Now it can support deploying rails project to our current sub directory.