untoldone / bloomapi

Create APIs out of public datasources
https://www.bloomapi.com/documentation/public-data
MIT License
89 stars 29 forks source link

Added index creation for zip, last_name, and zip+last_name to schema set up as well as added some quick documentation to `node make` #2

Closed marks closed 11 years ago

marks commented 11 years ago

Sorry about commits 9805de8, 9bf6bb3, and f43c365 .. should have 'cherry-picked' the commits to merge but couldn't figure out how without a lot of backtracking.

marks commented 11 years ago

Now that I think about this, it could probably use some refactoring by taking the index creation away from the database creation so removal and re-creation of the database is not required.

untoldone commented 11 years ago

Want to review my comments and let me know when to merge? I'll just add you as a contributor after this and we can start to just use pull as a way to gate checkins pending review (given we are both new to node) for each other but we can both commit to master etc when we have time.

marks commented 11 years ago

@untoldone - I believe I addressed all your comments and made some corrections in terms of switching to camelCasing and have also changed my IDE to use spaces from now on. I'll let you choose if/when to pull the "merge pull request" trigger. Thanks!