search

untoldone / bloomapi

Create APIs out of public datasources
https://www.bloomapi.com/documentation/public-data
MIT License
89 stars 29 forks source link

jsonp/ CORS #33

Closed untoldone closed 9 years ago

untoldone commented 11 years ago

implement support for one, the other, both

theworkerant commented 10 years ago

Perhaps you could add callback here:

https://github.com/untoldone/bloomapi/blob/master/lib/api/search.js#L5

Or if that doesn't work because optionalParams expects a number, maybe a custom else if here:

https://github.com/untoldone/bloomapi/blob/master/lib/api/search.js#L65

I'd put in a pull request but node is really not my forté so it would be untested.

untoldone commented 10 years ago

I think this makes sense. I've been spending most of my free time rewriting a chunck of the data loading/ query code and haven't looked at this myself. If you do submit a pull -- I'll review, test and deploy it if it makes sense.

theworkerant commented 10 years ago

Okay let's try it, I'm not actually 100% sure this is proper jsonp, but if it works it works.

Pull request: https://github.com/untoldone/bloomapi/pull/54

untoldone commented 9 years ago

Support for JSONP has now been added with commit 0279a797d9660b0661cd0ecf25e3304b4376885e. This will be deployed once v0.2.1 is released.