Adds provider_business_practice_locations table and `node make geocode` task

untoldone / bloomapi

Create APIs out of public datasources

https://www.bloomapi.com/documentation/public-data

MIT License

89 stars 29 forks source link

Adds provider_business_practice_locations table and `node make geocode` task #52

Closed etagwerker closed 10 years ago

etagwerker commented 10 years ago

Hey!

This is my attempt to add geocoded locations to the BloomAPI.

For now, it just focuses on gathering the latitude and longitude inside the new provider_business_practice_locations table, which uses the npi column as primary key.

I've added an INSTALL.md to have more precise installation details (It's based on http://www.bloomapi.com/contribute)

By default, it uses mapquest although that could be easily changed to use other services supported by https://npmjs.org/package/node-geocoder

This pull request is based on issue #48 and not complete yet. It should also modify the API search mechanism to allow a user to search using a geographic point and a miles radius.

Please review the code and let me know if this is what you had in mind.

Thanks!

untoldone commented 10 years ago

Awesome! I'll review this in the next few days

etagwerker commented 10 years ago

@untoldone I am open to suggestions. I know that there is plenty of room for improvement.

For instance, I've added database.json which duplicates the configuration inside config.js - I did this because I like the idea of separating databases in environments, the way db-migrate does.

Let me know.

untoldone commented 10 years ago

Some feedback:

Any thoughts on a way to keep contribute/ install.md in sync? e.g. basing one on the other or vise-versa rather than having two different docs that have the same goal/ have to stay in sync?
database.yml wont play nice with ansible deployment as it is right now and means db config will live in two different places. Any way to just used config.js for migrations or to completely move everything from config.js to database.yml?
Best case would be geocoding is run regularly on its own in production to keep geocoding new addresses added as new npi information is imported. In addition, best case is geocoding is run as part of ansible deployment. Updating of NPI happens when running 'node make fetch' ... want to see if you can including firing of geocoding on new addresses after npi updates?
how do you see geocoding surfaced to devs? is your expectation that devs would just use DB directly rather than API?

untoldone commented 10 years ago

Thanks for the patch, but this no longer makes sense given the recent rewrite for v0.2.0