search

untoldwind / alfred2-layout

Alfred 2 Layout workflow
http://untoldwind.github.io/projects/alfred2-layout.html
199 stars 16 forks source link

Lay Full - doesn’t handle dock on the right side #5

Closed jothirams closed 9 years ago

jothirams commented 9 years ago

Hello,

I have an external monitor connected with my laptop. When I remove my external connection, my browser is resized correctly to my monitor. However, the browser is also visible below my dock, which is placed on the right side of the monitor.

When I choose "Lay Full", it doesn’t resize correctly and my browser is still behind the dock. However, when I try "Lay Left", and then "Lay Full", then the browser is correctly set with the dock being transparent.

Hope, the bug report is clear.

untoldwind commented 9 years ago

Now that you mention it, I remember that there was an ugly issue with the dock (i.e. the available screen-size was not correctly calculated on the internal API in certain situations). May I ask what MacOS version you are using? I tried to reproduce it under Yosemite (10.10) and it seemed to work correctly.

jothirams commented 9 years ago

I’m also using 10.10. The issue is reproducible only if/when you are able to drag your browser behind the dock and then try to resize. And normally you won’t be able to drag it (OSX blocks it), however when you come from a bigger external monitor into your laptop's screen the browser is extended behind the dock and I can see the issue.

untoldwind commented 9 years ago

Good news is that I was able to reproduce this. It indeed just seems to occure with multiple screens of different sizes.

Sad news is: The fix is rather uggly. Under the hood the numbers appear to be correct. I.e. the workflow first resizes the window, then moves the window, then resizes the window again (in case first resize was blocked by some constraint). For some reason both resizes are ignored in you situation (i.e. the window is somewhat stuck at its current size). I fixed this by changing the first resize to 90% of the desired size, which results in a short flicker.

I'm not entirely happy with this, but the most current version https://github.com/untoldwind/alfred2-layout/raw/master/Layout.alfredworkflow might fix your problem.

jothirams commented 9 years ago

Awesome.. I just tested it with the newer version and it works. Thanks for fixing it!