Bugfix website older and newer page button

🔤 Polyglot PR

For browsing the website, the order and newer button don't work correctly when not on the home page.

When translating the website into Simplified Chinese(🤭will make a pull request soon), I found this bug and tested it on my device.

If you click on the order button or newer button on /page2/, you would get a page 404. This is because the href attribute of the page buttons is not written in the correct format.

The code of the buttons is on indexl.html:


<div class="pagination">
  {% if paginator.next_page %}
    <a class="pagination-item older" href="{{ site.baseurl }}page{{paginator.next_page}}">Older</a>
  {% else %}
    <span class="pagination-item older">Older</span>
  {% endif %}
  {% if paginator.previous_page %}
    {% if paginator.page == 2 %}
      <a class="pagination-item newer" href="{{ site.baseurl }}">Newer</a>
    {% else %}
      <a class="pagination-item newer" href="{{ site.baseurl }}page{{paginator.previous_page}}">Newer</a>
    {% endif %}
  {% else %}
    <span class="pagination-item newer">Newer</span>
  {% endif %}
</div>

This causes generating wrong page URLs. For example, if you click on the newer button on page3, the final URL you get by the button would be /page3/page2 but not /page2

Solution:

Just add a / at the beginning of the href attributes of the a tags:


<div class="pagination">
  {% if paginator.next_page %}
    <a class="pagination-item older" href="/{{ site.baseurl }}page{{paginator.next_page}}">Older</a>
  {% else %}
    <span class="pagination-item older">Older</span>
  {% endif %}
  {% if paginator.previous_page %}
    {% if paginator.page == 2 %}
      <a class="pagination-item newer" href="/{{ site.baseurl }}">Newer</a>
    {% else %}
      <a class="pagination-item newer" href="/{{ site.baseurl }}page{{paginator.previous_page}}">Newer</a>
    {% endif %}
  {% else %}
    <span class="pagination-item newer">Newer</span>
  {% endif %}
</div>

I have tested it on my device, it worked well.

Type of change

[ ] Docs update (changes to the readme or a site page, no code changes)
[ ] Ops wrangling (automation or test improvements)
[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Sweet release (needs a lot of work and effort)
[ ] Something else (explain please)

Checklists

[x] If modifying code, at least one test has been added to the suite

untra / polyglot