search

untra / polyglot

:abc: Multilingual and i18n support tool for Jekyll Blogs
https://polyglot.untra.io
MIT License
410 stars 59 forks source link

A bug of I18n_Headers tag #208

Closed blackpill closed 1 month ago

blackpill commented 3 months ago

I've found a bug of I18n_Headers tag.

If the permalink of a page is assigned to 'xxx', the hreflang for default_lang is wrong, like <link rel="alternate" hreflang="en" href="https://polyglot.untra.ioseo/"/>, missed a "/" We can see the bug from the source code of https://polyglot.untra.io/seo/

If the permalink of a page is assigned to '/xxx', the hreflang for other languages are wrong, like <link rel="alternate" hreflang="es" href="https://polyglot.untra.io/es//seo/"/>

Please fix this minor bug. Thank you!

george-gca commented 2 months ago

So why is it working on the page?

blackpill commented 1 month ago

If the permalink of a page is assigned to 'xxx/', the hreflang for default_lang is wrong, like , missed a "/" We can see the bug from the source code of https://polyglot.untra.io/seo/

untra commented 1 month ago

Nice find @blackpill ! fix should be deployed in 1.8.1