fix: Default language should use the similar url pattern with other l… - Githubissues

untra / polyglot

:abc: Multilingual and i18n support tool for Jekyll Blogs

https://polyglot.untra.io

MIT License

417 stars 60 forks source link

fix: Default language should use the similar url pattern with other l… #211

Closed blackpill closed 3 months ago

blackpill commented 3 months ago

…anguages

🔤 Polyglot PR

If the permalink of a page is assigned to '/xxx', the hreflang for other languages are wrong, like If the permalink of a page is assigned to 'xxx/', the hreflang for default_lang is wrong. We can see the bug from the source code of https://polyglot.untra.io/seo/.

This href url is wrong. <link rel="alternate" hreflang="en" href="https://polyglot.untra.ioseo/"/>

We should add a slash for the default language in the template.

add a sweet (optional) meme

Type of change

[ ] Docs update (changes to the readme or a site page, no code changes)
[ ] Ops wrangling (automation or test improvements)
[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Sweet release (needs a lot of work and effort)
[ ] Something else (explain please)

untra commented 3 months ago

nice catch, thank you for the contribution! I'll try and get an i18n_headers test spec implemented.