search

untrobotics / website

Source code to our website (maybe)
MIT License
5 stars 9 forks source link

Changed banner on Login page #89

Closed henlegay closed 3 years ago

ntindle commented 3 years ago

Please add the .idea files to the .gitignore

sebastian-king commented 3 years ago

You need to remove your .idea files. These are specific to your IDE environment, if everyone checked out those files it would start reconfiguring everybody's JetBrains IDEs. These should be ignores in the root .gitignore file, if they are not, please can you add it.

sebastian-king commented 3 years ago

You have changed the link to activities.jpg but I don't see that file included in the PR?

ntindle commented 3 years ago

You have changed the link to activities.jpg but I don't see that file included in the PR?

This file already is up on the site. I verified it exist cause I thought the same.

sebastian-king commented 3 years ago

Apparently the activities.jpg file already exists. I don't think we should re-use the page banners. We have the ability to do something unique and creative for every page, and I think we should take advantage of that. Furthermore, one of the biggest UX benefits of having a unique banner for each page is that it makes it clearer what page you are on. You could get confused otherwise between two pages that have the same header. This can be especially confusing as you are sometimes unexpectedly redirected to the login page when you click on a protected link.

There's nothing particularly special about our current Mr Robot banner, I think I just googled "robot login" and found that. If you would like another image, I'll happily take submissions. Perhaps post it in the Discord first to get feedback from the whole team?

sebastian-king commented 3 years ago

PR superseded by #98. Closing.