search

untrobotics / website

Source code to our website (maybe)
MIT License
5 stars 9 forks source link

This fixed the resizing issue on mobile for the calendar #90

Closed henlegay closed 3 years ago

sebastian-king commented 3 years ago

This does indeed work! Nice job deploying it to dev. I think there are some things we want to discuss about this task in general, such as if we want to stick with the Google calendar classic view or move to something more modern (I think we previously talked about finding a better calendar library?). We can talk about these and review this PR together in our regularly scheduled meetings that @Peyton232 needs to schedule!

ntindle commented 3 years ago

Let’s merge this since it works now and talk about upgrading the calendar in the magic meeting that @Peyton232 will be scheduling

sebastian-king commented 3 years ago

Good point! Once the .idea files have been removed I’m happy to approve the PR

ntindle commented 3 years ago

You've done it!

Peyton232 commented 3 years ago

looks good

ntindle commented 3 years ago

LGTM (looks good to me)

Peyton232 commented 3 years ago

Shouldn't we make it *.idea

ntindle commented 3 years ago

.idea removes the folder

*.idea removes anything with that extension

ntindle commented 3 years ago

.idea/ And

*.idea could be prudent

ntindle commented 3 years ago

Just copy and paste this to the end of the file and let's call it a day

https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore

sebastian-king commented 3 years ago

Now that the PR is merged can you update the Jira ticket status to Ready for Production?