untrogen999 / don-quixote

Spring 2024 HUMAN-1050
2 stars 0 forks source link

Cameron Kile comment on Don Quixote Project #1

Open ckile55 opened 6 months ago

ckile55 commented 6 months ago

All around it was a great project. You guys had a wonderful presentation and made it clear and easy to understand what the project was about. I could see just how dedicated and determined you guys were working on it and it did indeed pay off. All three graphs were brilliant. I particularly loved Joe's network graph. It is cool to see how often each character appears and interacts with each other. Another thing I enjoyed was that you guys placed a hyperlink to your repo on the home page so users could see how the project was created. One particular thing I would like to critique though, was Avi's bubble timeline. While I love the idea and the way you executed it, there are some things that confuse me. During your explanation in class, you stated the bubbles and numbers correspond with one another but for a few, it does not exactly do that. For example, at the 20 mark on the first bubble timeline, there are 4 for Motteux(Red), 4 for Saavedra(Blue), and 3 for Ormsby(Green). While there are ticks for all three versions the bubble that it corresponds with only shows a red and green circle. This also occurs on the 60 mark on the first timeline and the 30, 40, 55, 65, and 70 marks on the second timeline. If I am misunderstanding the concept please feel free to respond and correct me. Otherwise, a great project in all and you guys should be proud. Have a great summer!

haggis78 commented 6 months ago

@ckile55 you identified an issue with certain data combinations. If the numbers for a chapter group are 3, 5, and 6, you'll see it looking like a bullseye target (Avi wrote the code to put the smallest circles in front, so you'd always be able to see them). But when you have two circles that are the same size, one of them will perfectly overlap with the other, and so one will be completely hidden. This was an experiment in data visualization, and one thing to be learned from it is that it doesn't work perfectly in all circumstances.