search

untyped / sbt-plugins

SBT plugins for Javascript, Coffeescript, LESS, SASS, and Mustache compilation
73 stars 23 forks source link

support for sbt 0.13 #34

Closed shiphrah closed 11 years ago

shiphrah commented 11 years ago

support for sbt 0.13 would be great :-)

japgolly commented 11 years ago

SBT 0.13.0 final was just released and is currently incompatible with sbt-js 0.5.

mdedetrich commented 11 years ago

Confirming what is said above, should probably aim for SBT 0.13 support in 0.6 release

davegurnell commented 11 years ago

Agreed. And sorry for my lack of response on this-not had much time to spend on it recently. Will aim to put a couple of hours in today towards 0.6.

-- Dave

On 4 Sep 2013, at 00:00, mdedetrich notifications@github.com wrote:

Confirming what is said above, should probably aim for SBT 0.13 support in 0.6 release

— Reply to this email directly or view it on GitHubhttps://github.com/untyped/sbt-plugins/issues/34#issuecomment-23754019 .

davegurnell commented 11 years ago

I've started working on this in a branch called feature/sbt-0.13. Having some trouble with xsbt-web-plugin. Will keep this thread updated as I progress.

mdedetrich commented 11 years ago

Are you using this sbt plugin https://github.com/JamesEarlDouglas/xsbt-web-plugin?

japgolly commented 11 years ago

I see that you've updated project/Build.scala to use 0.4.2 of xsbt-web-plugin and changed the groupID - that looks good - but I noticed that similar changes are missing from sbt-runmode/src/sbt-test/sbt-runmode/base/project/plugins.sbt. I don't suppose that's related to the problem you are having?

japgolly commented 11 years ago

Is there anything I can do to help out with this? This is the only plugin stopping me from upgrading my project to 0.13 which I need to finally get my unit tests running in parallel again, so happy to lend a hand here if I can.

davegurnell commented 11 years ago

Many apologies for my lack of progress on this.

I started this work a month ago but hit a wall. It seems to be incredibly difficult to get a build going that compiles and tests under all applicable versions of SBT and Scala.

I think I made some progress today. I've pushed v0.6-M5, built against SBT 0.13 / Scala 2.10, to ivy.untyped.com:

http://ivy.untyped.com/com.untyped/

Can you confirm whether it works for you? If it does, I'll put together a stable 0.6 and release it to the central SBT plugins repo.

Dave

japgolly commented 11 years ago

I just gave it a try and as far as I could tell, it works perfectly! Thank you for the hard work.

(Specifically I tested 0.6-M5 with SBT 0.13 & Scala 2.10.3 on Java 1.7.40b43.)

mdedetrich commented 11 years ago

Dammit, I just made a pull request for sbt-untyped for sbt 0.13 and scala 2.10.3, ill see if there are any differences and if there is a reason to merge

@davegurnell what branch has these SBT changes, also, how did you deal with the xbst-web-plugin, in my case I needed to update it to make it work with SBT 0.13.0

davegurnell commented 11 years ago

Glad it works! I'll ship 0.6 proper in the next week or so.

Dave

On 9 October 2013 13:49, mdedetrich notifications@github.com wrote:

Dammit, I just made a pull request for sbt-untyped for sbt 0.13 and scala 2.10.3, ill see if there are any differences and if there is a reason to merge

— Reply to this email directly or view it on GitHubhttps://github.com/untyped/sbt-plugins/issues/34#issuecomment-25968049 .

davegurnell commented 11 years ago

Dang - I merged this PR and then realised it was for master. Silly mistake on my part.

davegurnell commented 11 years ago

SBT 0.13 compatibility introduced in release v0.6.