search

untyped / sbt-plugins

SBT plugins for Javascript, Coffeescript, LESS, SASS, and Mustache compilation
73 stars 23 forks source link

Adds a sbt-sass plugin #48

Closed torbjornvatn closed 10 years ago

torbjornvatn commented 10 years ago

I was in need of a sbt plugin for compiling Sass files at work. After some trial and error of testing the existing plugins out there I stumbled over this project and decided to port the sbt-less plugin.

I've included the necessary parts of the latest sass gem (3.2.14) and uses JRuby to call sass for compiling.

Could you please take a look and tell me what you think of it?

Regards Torbjørn

torbjornvatn commented 10 years ago

I had some problems running the scripted tests for sbt-less by the way

[error] (sbt-less/*:scripted) Failed tests:
[error]     sbt-less / base
[error]     sbt-less / include-exclude
[error]     sbt-less / source-dirs
davegurnell commented 10 years ago

Hi Torbjørn,

This looks great! I haven't given it a thorough look yet but I will do today/tomorrow.

Dave

On 7 February 2014 20:06, Torbjørn Vatn notifications@github.com wrote:

I had some problems running the scripted tests for sbt-less by the way

error Failed tests: [error] sbt-less / base [error] sbt-less / include-exclude [error] sbt-less / source-dirs

Reply to this email directly or view it on GitHubhttps://github.com/untyped/sbt-plugins/pull/48#issuecomment-34496567 .

Dave Gurnell, Untyped http://untyped.com 07967 004805

torbjornvatn commented 10 years ago

Thats great Dave, please let me know if there's something I need to clarify

/t

torbjornvatn commented 10 years ago

@davegurnell Had to make some changes to get all the imports to work

I've started testing the plugin in a real life project at work, so any quirks will surface there I guess :grin:

davegurnell commented 10 years ago

LGTM!

Sorry it took a while to get around to this. Lots of projects on the go at the moment.

My only initial reservation was about having such a large codebase for SASS in the repo, but on reflection I think it's good: (a) it's basically what we're doing for LESS (but SASS is loads bigger), and (b) it does mean we keep a tight eye on the version of SASS (which is good).

davegurnell commented 10 years ago

I've pushed a fix to develop for those broken sbt-less tests.

Let me know how your testing of sbt-sass goes. Once you're happy it's stable I'll publish a 0.7 release.