search

untyped / sbt-plugins

SBT plugins for Javascript, Coffeescript, LESS, SASS, and Mustache compilation
73 stars 23 forks source link

Fix for allowing compile error message of less compiler to be a ConsString also. #52

Closed rkaercher closed 10 years ago

rkaercher commented 10 years ago

I had the case in which the less task was issuing the following error when compiling and a variable wasn't defined properly in less: error java.lang.ClassCastException: org.mozilla.javascript.ConsString cannot be cast to java.lang.String

After this fix the error message is displayed correctly: error sbt-less error: components.less [44,20]: variable @lightGreyBG is undefined

Some errors still returned String as error message so the match seems necessary to accomodate both.

I would be glad if this would make it into the 0.8 release as I was getting this error quite frequently.

Kind regards, Roland

davegurnell commented 10 years ago

LGTM. Thanks for the fix!

I've merged the fix and published version 0.8-M1 on ivy.untyped.com:

http://ivy.untyped.com/com.untyped/sbt-less/scala_2.10/sbt_0.13/0.8-M1

The fix will go out in the final 0.8 as well.

Dave