search

untyped / sbt-plugins

SBT plugins for Javascript, Coffeescript, LESS, SASS, and Mustache compilation
73 stars 23 forks source link

Filename suffix #58

Closed joescii closed 10 years ago

joescii commented 10 years ago

Here is a PR for resolving my suggestion in #55. I figured out how to test (see PR #57), and I was able to update the base tests for the three affected projects to utilize this feature. I considered making a separate test project for this new feature, but I thought that might be a bit overkill. Let me know if there is anything else needed for this PR to be acceptable.

davegurnell commented 10 years ago

The code looks LGTM. Ideally I'd like to preserve the 'base' test cases and add a new test case for the filename suffixes. I'll take care of this when I merge the PR at some point today.

joescii commented 10 years ago

Ah, ok. If you get too busy, let me know and I'll break them out into separate tests in the afternoon. Also if you are able, let me know your thoughts on the other issues/PRs I opened. I may have some time for those today.

Joe

On May 16, 2014, at 4:21, Dave Gurnell notifications@github.com wrote:

The code looks LGTM. Ideally I'd like to preserve the 'base' test cases and add a new test case for the filename suffixes. I'll take care of this when I merge the PR at some point today.

Cheers,

Dave

— Reply to this email directly or view it on GitHub.

davegurnell commented 10 years ago

I've merged this in and published it to http://ivy.untyped.com as 0.8-M2. Thanks for the great contribution!