unumux / willow

HTML and SCSS for common UI components built by the Unum UX team
GNU General Public License v3.0
6 stars 2 forks source link

Grid: Long words inside grid__item cause incorrect widths #122

Open chuckhendo opened 6 years ago

chuckhendo commented 6 years ago

A long word inside of a griditem causes the griditem to be wider than it's flex-basis indicates it should be. One way to fix this seems to be:

  1. Set width on grid__item to be the same as flex-basis
  2. Set word-wrap: break-word
  3. Find some way to hyphenate?
Keale2 commented 6 years ago

I suspect any component with long words will break any component they are used in, so we may want to consider a solution that addresses more than grid__item.

We can consider hyphens: auto at a higher level.

chuckhendo commented 6 years ago

@Keale2 Agreed. I think 2 and 3 could potentially be handled at a higher level. 1 still needs to be completed on this component in order for those to work properly though