Various fixes to the live preview

keichan34 commented 1 year ago

Description

Fixes #88, fixes #125, fixes #128, in addition to the issues below:

The mapbox provider was broken because mapboxgl.Map was mistakenly replaced with maplibregl.Map
Added automatic zoom/center to the Geolonia provider
Add layer control to the Geolonia provider
Throw an error if the Mapbox access token is not set when using the mapbox provider

Type of Pull Request

[ ] Adding a feature
[x] Fixing a bug
[ ] Maintaining documents
[ ] Others ()

Verify the followings

[x] Code is up-to-date with the main branch
[x] No build errors after npm run build
[x] No lint errors after npm run lint
[x] No errors on using charites help globally
[x] Make sure all the exsiting features working well
[ ] Have you added at least one unit test if you are going to add new feature?
[ ] Have you updated documentation?

ubukawa commented 1 year ago

I experienced "permission denied" when I run "convert" although I had a permission to make files in that directory. (both in docker and my linux environment.) I did not experienced this before, but is it some how related to this pull request??

For example, in the Docker. It is okay with the previous version.

But, if I uninstalled it and installed this version, it did not work...

keichan34 commented 1 year ago

@ubukawa Sorry about this, I forgot to rebase on the current master after merging #121 , which fixes this issue. There's a separate issue where errors where the file has failed to write are being swallowed and replaced with a generic "permission denied" error, which I just reported in #130. It should be working now (I tested with your https://github.com/ubukawa/cmv-test/ repository on Mac -- I'll try again in Linux later today)

keichan34 commented 1 year ago

@naogify

Added automatic zoom/center

This feature was added in #119, but only to default and mapbox providers -- I applied it to the geolonia provider as well. It's different from the default behavior because in addition of looking at the style, it also looks at the tile data sources. The bug I fixed in relation to this feature was #128

unvt / charites