E2E Testing the live preview feature of charites by playwright - Githubissues

unvt / charites

It is an application to style vector tiles easily

https://unvt.github.io/charites/

MIT License

51 stars 13 forks source link

E2E Testing the live preview feature of charites by playwright #132

Closed yuiseki closed 1 year ago

yuiseki commented 1 year ago

Is your feature request related to a problem? Please describe.

The live preview feature is very important for charites.
However, this functionality is written in Javascript, not Typescript, and is not software tested, so it is easily broken if changed.

Describe the solution you'd like

So, I propose to add E2E testing by playwright for the live preview feature
E2E testing can be very costly, but is worth considering for testing critical functions.

Describe alternatives you've considered

Another option would be to Typescript-ize the Live Preview feature, but this would involve major changes.

Additional context

I fixed the LegendControl feature in the live preview that was broken sometime ago
My previous pull request broke the live preview feature.
- 119
It have fixed in this pull request.
- 129
As such, the live preview function is difficult to manually verify the operation for various cases and can be easily broken
I want to prevent this from happening again.
I have already started to implement Playwright with the following pull request
- 131