Charites v2: Drop support providers, rewrite all to esm module

unvt / charites

It is an application to style vector tiles easily

https://unvt.github.io/charites/

MIT License

54 stars 13 forks source link

Charites v2: Drop support providers, rewrite all to esm module #178

Closed smellman closed 2 months ago

smellman commented 3 months ago

Thank you for submitting a pull request!

Description

Please describe what you changed briefly.

Drop support Mapbox and use current MapLibre Style Spec
Rewrite all module to esm
Use eslint 9.x

Type of Pull Request

[x] Adding a feature
[ ] Fixing a bug
[x] Maintaining documents
[ ] Others ()

Verify the followings

[x] Code is up-to-date with the main branch
[x] No build errors after npm run build
[x] No lint errors after npm run lint
[x] No errors on using charites help globally
[x] Make sure all the existing features working well
[ ] Have you added at least one unit test if you are going to add new feature?
[x] Have you updated documentation?

Refer to CONTRIBUTING.MD for more details.

JinIgarashi commented 3 months ago

@smellman I would suggest you split this PR into two:

drop mapbox supports;
And all other changes.

dropping mapbox support can be a breaking change, it would be nice if you can make a PR which only focus on that. You can increase a major version after removing mapbox if we follow semantic versioning

smellman commented 3 months ago

My main motivation is convert to ESM module from CommonJS and support MapLibre v4, so dropping mapbox support is related of this.

smellman commented 2 months ago

~idea: Create migration command from 0.5.4 to 2.0.0/1.0.0.~ Thanks you @keichan34

JinIgarashi commented 2 months ago

@smellman could you also do this issue in this PR? also please upgrade maplibre version from 2.4.0 to latest 4.6.0. currently, version is hard coded

https://github.com/unvt/charites/issues/179

smellman commented 2 months ago

@smellman could you also do this issue in this PR? also please upgrade maplibre version from 2.4.0 to latest 4.6.0. currently, version is hard coded

179

maplibre version is not hard coded now. But currently I don't care about NPM module, because I don't know how to apply npm module inside provider directory.