unvt / charites

It is an application to style vector tiles easily
https://unvt.github.io/charites/
MIT License
51 stars 13 forks source link

Can charites serve work properly on Linux? #88

Closed ubukawa closed 1 year ago

ubukawa commented 2 years ago

Warm greeting! Thank you once again for the charites development!

After my work in my own PC, now I would like to share the styling work with my colleagues and use charites in Linux. I have found some issue here. I would appreciate if if you could kindly confirm it!

Describe the bug During charites serve, updated file is not detected automatically.

To Reproduce Steps to reproduce the behavior:

Expected behavior Even in Linux, I expected that the update/edit of yml file is automatically detected and live-view automatically update.

Screenshots If applicable, add screenshots to help explain your problem. 2022-01-24-charites

Charites Version:

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

keichan34 commented 1 year ago

When I tried this (server: Ubuntu Linux, browser: Chrome on macOS on another PC), I got an error in the console:

WebSocket connection to: `ws://localhost:8080` failed

Because the WebSocket connection is used to tell the browser about new updates to styles, I think that this may be the culprit. A fix to dynamically change the hostname of the WebSocket connection may help?

https://github.com/unvt/charites/blob/main/provider/default/app.js#L7 https://github.com/unvt/charites/blob/main/provider/geolonia/app.js#L7 https://github.com/unvt/charites/blob/main/provider/mapbox/app.js#L9