error: won't compile on CentOS 7 64bit

[grkblood13]

I'm getting the following 2 errors when compiling on CentOS 7:

gitbrowser.c:1319:53: error: 'GtkDialog' has no member named 'action_area' gtk_box_pack_start(GTK_BOX(GTK_DIALOG(qoi->dialog)->action_area), hbox, TRUE, TRUE, 0);

gitbrowser.c:1320:56: error: 'GtkDialog' has no member named 'action_area' gtk_box_recorder_child(GTK_BOX(GTK_DIALOG(qoi->dialog)->action_area), hbox, 0);

[unwind]

Okay, first: thanks a lot for reporting this. I had no idea that anyone but me uses this software, and learning that someone cares is always cool!

Second: please add the output of running:

$ pkg-config --modversion gtk+-3.0

on your system. I seem to have 3.22.25 (Ubuntu 17.10), and for me it builds. GTK+'s documentation wasn't clear that this field has been removed either, so right now I'm a bit confused.

[grkblood13]

I have 3.22.10

[grkblood13]

And no problem reporting it. I wouldn't say I'm using it yet though, but I'd like to. :) I really like Geany so I'd like to keep it as my IDE when working on git projects, so right now I'm trying to incorporate whatever git plugins I can find. I see that your tool doesn't allow you to check anything in which would be nice but beggars can't be choosers.

[unwind]

Thanks.

I'm stumped though, this makes no sense.

• You get a deprecated-warning on an older version of GTK+ than the one I use, while I don't get a warning. Wut?
• The docs discourage accessing the field directly but don't deprecate it.

Confused.

[grkblood13]

Have you tried building on a CentOS 7 VM?

Sent from my iPhone

On Mar 31, 2018, at 9:27 AM, Emil Brink notifications@github.com wrote:

Thanks.

I'm stumped though, this makes no sense.

You get a deprecated-warning on an older version of GTK+ than the one I use, while I don't get a warning. Wut? The docs discourage accessing the field directly but don't deprecate it. Confused.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[unwind]

Uh, okay, just realized Geany builds using GTK+ 2, not GTK+ 3.

So, what's the output of pkg-config --modversion gtk+-2.0 on your system? Mine is 2.24.31.

I did try the VM route, but it's verrry slow going (I'm not at all used to working with virtual maches).

[unwind]

I just pushed a tiny change which avoids the direct access of action_area, please let me know if that changes anything. Thanks.

[grkblood13]

So that time it built and it created /usr/lib64/geany/gitbrowser.so

The plugin is not showing up in the plugin manager though.