search

unwire / handsoap

Handsoap is a library for creating SOAP clients in Ruby
http://github.com/unwire/handsoap
225 stars 58 forks source link

Curb or httpclient by default ? #13

Closed jlecour closed 14 years ago

jlecour commented 14 years ago

Hi,

I've read that curb is the default http driver, but in "lib/handsoap/parser.rb" I see an explicit require for "httpclient".

Is it a mistake or I'm missing something ?

Thanks

troelskn commented 14 years ago

Handsoap::Parser is not part of the runtime for Handsoap - It's only used by the generator. I guess it could use the http-abstraction layer just like the rest of the library, but I figured it didn't matter much for the generator. Call me lazy.

jlecour commented 14 years ago

Thank you for this quick answer. I won't call you lazy ;-) I just wish It'd have been written somewhere, for example a comment just above the "require", but that said, it's not a problem, I installed 'httpclient' and it worked as expected.

Thanks again.

troelskn commented 14 years ago

I'll pop a comment in there. The nice thing about httpclient is that it's all ruby code, so it works the same across different platforms. It's slow as molasses though, so it's not a good pick for runtime.