uob-positron-imaging-centre / up4

Post-processor for particle data.
https://uob-positron-imaging-centre.github.io/up4/
GNU General Public License v3.0
9 stars 1 forks source link

Pyo3 upgrade #28

Closed DanW97 closed 1 year ago

DanW97 commented 1 year ago

We are 4 minor versions behind on pyo3 (0.14 vs 0.18). This pull request has ported over to the new version, and also has fixed some doc stuff.

Key changes from 0.14 - 0.18

  1. [args(...)] is now deprecated, instead you use #[pyo3(signature(arg1, arg2, arg3 = value)], a caveat is that you need to include all args defined in the function below (except the _py and self like ones)

  2. [pyproto] is no longer needed - all dunder method stuff is now working under #[pymethods]

All tests pass