search

uoft-project1-group5 / cocktail-map

https://uoft-project1-group5.github.io/cocktail-map
1 stars 0 forks source link

Issue 18: Recent searches list no longer pushes down search bar #23

Closed TerrenceJChan closed 3 years ago

TerrenceJChan commented 3 years ago

By removing the grid-x class from the search bar's wrapper, the search bar no longer moves down with a long list.

Additionally, I removed the 40vw styling since it was causing some spacing issues.

By making the body 100vw and a flex object, I was able to ensure that the footer stays at the bottom of the page. If there is a lot of content on the page, then it will move down so that it does not overlap other things.

Please review the pull request and accept the changes if they're okay! Otherwise, please send it back to me for review.

shanshantina commented 3 years ago

Hi Terrence, I have made those changing in here, so you don't need to pull this issue feature to develop, thanks