search

uoft-project1-group5 / cocktail-map

https://uoft-project1-group5.github.io/cocktail-map
1 stars 0 forks source link

HTML/CSS - adapt to small and big screens #16 #24

Closed shanshantina closed 3 years ago

shanshantina commented 3 years ago

I have add mediaquery to both pages, please review and let me know, so I can pull them to develop branch. thank you

TerrenceJChan commented 3 years ago

Hi @shanshantina , I love the code! The text and cells are all very responsive and fit the screen well! Things properly stack on top of each other when the size gets smaller. The search history also nicely stacks in a way that smartly conserves space. Well done!

My one concern deals with the logo and the top navbar when the size changes. At certain sizes, the logo and menu text become smaller than the regular text on the screen. Is it possible at all set a minimum size for them?

shanshantina commented 3 years ago

Hi Terrence, I have made some changes to logo and navigator bar, can you check it for me? thanks

TerrenceJChan commented 3 years ago

It looks good! We just have to clear the conflicts and we can merge this into develop.