uoft-tapp / old-orig-tapp

TA assignment and matching application.
0 stars 2 forks source link

HLP courses are not in the app #175

Open reidka opened 6 years ago

reidka commented 6 years ago

The HLP courses appear in the JSON file exported from CHASS, but do not appear in the app after import.

For example, the following appears in the JSON, but I don't see the course anywhere in the app.

        {
            "course_id": "HLP101H1",
            "course_name": "Help Centre TA",
            "round_id": "110",
            "enrollment": "N/A",
            "n_positions": "6",
gabriellesc commented 6 years ago

Would it be possible for @alynch to change the dates input fields in CHASS to date inputs, or something equivalent such that the dates are always in a consistent format?

reidka commented 6 years ago

Maybe. We can ask.

alynch commented 6 years ago

The JSON file has date/time fields of the form: "last_updated": "2017-07-31 23:57:09"

which is valid ISO_8601 format [1]. What format would you prefer?

[1] (a) The separator between date and time is normally 'T', but it's allowed to omit it by agreement between the parties. (b) We are not using a time zone designator.

reidka commented 6 years ago

Hi @alynch, the field in question sis the "dates" field in the courses. It is a text box in the application, and I filled it in (at least) two different ways.

alynch commented 6 years ago

Oh, sorry, my misunderstanding. Unfortunately the 'dates' field is a text field that departments use to indicate the duration of the appointment, and sometimes they use the field to add extra details. It would be quite a bit of work to convert it to two date fields (and a extra text field for extra info).

gabriellesc commented 6 years ago

@alynch would it be possible to add helptext and/or formatting validation to the field to suggest and/or enforce that the data is entered in a fixed format - while still allowing additional text? For example:

<input type="text" placeholder="dd/mm/yy - dd/mm/yy" pattern="[0-9]{2}/[0-9]{2}/[0-9]{2} - [0-9]{2}/[0-9]{2}/[0-9]{2}.*" />

which would enforce the date format "dd/mm/yy - dd/mm/yy" but allow as much subsequent additional text as desired?