search

uoft-tapp / old-orig-tapp

TA assignment and matching application.
0 stars 2 forks source link

Fix issue #147: Added a visual indicator of import being in progress #182

Closed gabriellesc closed 7 years ago

gabriellesc commented 7 years ago

While an import to CHASS is in progress, a spinner is displayed in place of the import button.

~This will need to be refactored on top of #181~

Update:

Rather than refactoring this on top of #181, I attempted to create a new branch off development and recreate these changes in that branch. However, I accidentally made these changes directly in development, in https://github.com/uoft-tapp/tapp/commit/f1df6b882b919a78c36775b157035a775bdf1dad

simpslandyy commented 7 years ago

@gabriellesc is this also a hotfix??

gabriellesc commented 7 years ago

@simpslandyy I don't think so? @jmzaleski you requested this change - what do you think?

simpslandyy commented 7 years ago

@gabriellesc @jmzaleski - this is more of a nice feature to have, rather than a bug that will break the system. I think it can wait until the next release.