search

uoft-tapp / tapp-cp

TA assignment and matching application (TAPP) & Contract Presentment helper (CP) at the Department of Computer Science, University of Toronto
8 stars 6 forks source link

Merging the Development Branch from Our Fork #148

Closed edward0414 closed 6 years ago

edward0414 commented 6 years ago

Merging the instructor-switch feature and instructor landing page feature into a "development" branch

nigef commented 6 years ago

Nice, just adding here what you @edward0414 @jsyoon01 already know,

Fixes the top bullet in #143, though the modal doesn't come up and my browser window freezes when clicking the last name. I haven't been able to spot the reason in the code, yet.

Fixes the fourth bullet in #144 for the unassigned-table. Would it be possible to also fix the alignment for the assigned-table?

Fixes #145.

nigef commented 6 years ago

@jsyoon01, what do you think? I think this merge should be revered for two reasons: • The modal bug causes the browser window to freeze. • The instructor view search feature idea may have arisen due to a misunderstanding. Probably we should not have the search feature to switch utorid. Otherwise if the feature is useful, switching to another utorid should lock down to a read-only mode, or something like that, because we don't want users to morph into other users.

edward0414 commented 6 years ago

@nigef I agree. I merged the branch at first because I thought it is just a small branch for Sungyoon and I. Now we figuring out the workflow and knowing that it's main branch for this summer group to push to, it is a good idea to not merge the PR until everything is working.