uoft-tapp / tapp-cp

TA assignment and matching application (TAPP) & Contract Presentment helper (CP) at the Department of Computer Science, University of Toronto
8 stars 6 forks source link

Import: empty courses and preferences breaks importer #152

Open reidka opened 5 years ago

reidka commented 5 years ago

If the JSON file has a null course_preference field, then we get an internal server because parse_preference in chass_importer.rb fails. In this case it is just because there is no case to handle null.

This actually gets at another bug. Students leave course_preferences blank, and in this case their preferences should be the list of courses.