[WIP] Fix development + Hook up new DDAH UI - Githubissues

uoft-tapp / tapp-cp

TA assignment and matching application (TAPP) & Contract Presentment helper (CP) at the Department of Computer Science, University of Toronto

8 stars 6 forks source link

[WIP] Fix development + Hook up new DDAH UI #155

Closed michellemtchai closed 2 years ago

michellemtchai commented 5 years ago

based on PR #154
based on @nigef's branch master-ddah
purpose:
- fix issues where appState function (CP) makes the app freeze up or render blanks
- cause: needed to wait for fetch to load before using db-related appstate function
- fix webpacker loading issue
- cause: due to moving of packs in the erb file from outside to inside of the check for development
- clean up hard-coded data to use provided mock data
- this is a by-product of attempting to find the above 2 issues
- reactify the code for readability
- this was the means used to attempt to clean up the code
- fix the image loading issue with UofT logo
please use the following files for populating the database:
- TAPP:
- semester 1: db/seeds/fake-chass-applicant-import-CSC999.json
- semester 2: db/seeds/make-fake-chass-applicant-import-CSC300.json
- CP:
- db/seeds/fake-offer-for-csc999-tas.json
- db/seeds/matz-fake-offer-for-csc300-tas.json
- The semester 1 file for TAPP is an updated version, please import it again even if it is already in your local
the React hierarchy is kind of like: