search

uoft-tapp / tapp

MIT License
9 stars 24 forks source link

Add star and note to matching dropdown & decouple functions from dropdown code #694

Closed elaine-huynh closed 1 year ago

elaine-huynh commented 1 year ago

This PR adds "star" and "add note" options to the dropdown lists when clicking on applicant pills.

Some matching functions have also been decoupled from the dropdown and moved to a separate directory in order to support reuse in future updates (e.g., implementation of a student-based view and adding functionality to the table view).

siefkenj commented 1 year ago

There appears to be a merge conflict to fix

siefkenj commented 1 year ago

This is looking really close! Have you looked into immer yet? I think it would make the reducers look much nicer.

elaine-huynh commented 1 year ago

I think immer looks good but perhaps should be a separate PR to incorporate it into other components as well? I do agree that it would probably make reducers look nicer.

siefkenj commented 1 year ago

Okay. Immer can be done in a different PR.