search

uohzxela / heka-s3

Heka output plugin for AWS S3
13 stars 7 forks source link

Building on heka master? goamz dependency conflict #3

Open bryanlarsen opened 7 years ago

bryanlarsen commented 7 years ago

I tried building this into current heka master.

I got an error saying that the mitchellh/goamz dependency couldn't be found.

I converted the mitchellh/goamz import in your code to the AdRoll/goamz that's included in heka, and I got:

heka/src/github.com/uohzxela/heka-s3/s3_output.go:58: not enough arguments in call to aws.GetAuth
heka/src/github.com/uohzxela/heka-s3/s3_output.go:245: not enough arguments in call to so.bucket.Put

I tried adding mitchellh/goamz to heka/cmake/externals.cmake and got:

  add_custom_target cannot create target "goamz" because another target with
  the same name already exists.  The existing target is a custom target

Any recommendations? Should I build against a different version of Heka? Is this project abandoned given that Heka itself is deprecated?

jpereira commented 7 years ago

+1

jpereira commented 7 years ago

@bryanlarsen I have fixed the plugin, please take a look in my forked version https://github.com/jpereira/heka-s3

jpereira commented 7 years ago

@bryanlarsen I sent an pr to the maintainer as can be seen here https://github.com/uohzxela/heka-s3/pull/5