search

uon-nuget / UoN.ExpressiveAnnotations.NetCore

Annotation-based conditional validation library.
Other
29 stars 12 forks source link

use attribute id if available for weakid to fix arrays validation 27 items #34

Open izakbar opened 1 year ago

izakbar commented 1 year ago

fix for #31 when using arrays of data preventing validation working as weakid sees each as same id.

MmmBerry commented 1 year ago

Is this basically the fix in 2.6.6 on the original (Framework) version of this package, or a new approach to solving the problem of the 26-attribute limit?

As I commented earlier, I'm uncomfortable with accepting any change that I don't have time to test, especially if it's a change that was implemented and then rolled back in the original repo, but if this is a new approach it might strengthen the case for forking and publishing a new package that gets around the limit of 26. However, it seems to me that a limit of 26*26 = 676 attributes would be the ideal solution - after all, "640K should be enough for anyone" - but from a glance at the code in both proposals it doesn't seem like either solution is actually doing that.