search

uoregon-libraries / oregon-oni

Oregon theme / customizations for use with Open ONI
1 stars 0 forks source link

Did we lose image attribution? #37

Closed jechols closed 7 years ago

jechols commented 7 years ago

I thought we had this on pages, and I'm not seeing it for example on https://oregonnews.uoregon.edu/lccn/sn96088073/1909-09-24/ed-1/seq-1/. It does appear to be in the page's metadata, though:

    <meta property="og:description" content="Cottage Grove sentinel. (Cottage Grove, Or.) 1909-current, September 24, 1909, Image 1, brought to you by University of Oregon Libraries; Eugene, OR, and the National Digital Newspaper Program." />
jechols commented 7 years ago

@lsat12357 - am I nuts or did this info used to show up on the pages?

lsat12357 commented 7 years ago

Well, you’re nuts, but that’s a separate issue. We did have attribution info, based from the organization? code that we sometimes were manually adding in the database.

From: Jeremy Echols notifications@github.com Reply-To: uoregon-libraries/oregon-oni reply@reply.github.com Date: Wednesday, August 30, 2017 at 9:45 AM To: uoregon-libraries/oregon-oni oregon-oni@noreply.github.com Cc: Linda Sato lsato@uoregon.edu, Mention mention@noreply.github.com Subject: Re: [uoregon-libraries/oregon-oni] Did we lose image attribution? (#37)

@lsat12357https://github.com/lsat12357 - am I nuts or did this info used to show up on the pages?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/uoregon-libraries/oregon-oni/issues/37#issuecomment-326050280, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHLZHiO3JtBqXxP-Qi2q8UR1QDf94cMvks5sdZHEgaJpZM4PHq6M.

jechols commented 7 years ago

Okay, I'll see about fixing this then

jechols commented 7 years ago

There's now a PR for ONI that will fix this: https://github.com/open-oni/open-oni/pull/306