search

uoregon-libraries / oregonnews

!!Defunct!! University of Oregon fork of Chronicling America
1 stars 0 forks source link

Rip out page.js customizations #11

Closed jechols closed 7 years ago

jechols commented 10 years ago

I did a bunch of minor tweaks on the page.js, but overriding this file makes it much tougher for us to keep in sync with core. I think we can just rip out those customizations and stick them in their own file, included in the same pages that use page.js. This would mean when the upstream page.js changes, so does ours.

jechols commented 10 years ago

This isn't as easy to do as I was hoping - we have modified some code within the core resizePrint() handler in order to change the clip's class so that when open seadragon is animating, you can visibly see that you can't clip the view; when animation is done, the view is clearly clippable again. I'm not sure we can pull that code out, so it might make more sense to instead try and push our page.js customizations upstream - they should be backward compatible, they just allow CSS to be used to style the #clip element depending on the class.

jechols commented 7 years ago

No longer relevant with ONI switch pending