search

uoregon-libraries / uolib-primo-nui

University of Oregon Libraries implementation of the Primo New UI
0 stars 0 forks source link

JS: make LOCAL_VID pull from the current URL #45

Closed jechols closed 2 years ago

jechols commented 2 years ago

Right now our javascript has a hard-coded view id, which makes for problems when testing new views. It's almost certainly possible to pull the view id from the URL, and only hard-code it if there's not already a set value.

jechols commented 2 years ago

Looking into this some, it's going to take a bit of work. The vid is only used in a couple places, but the view path, which is now different from the view id (in non-VE it's the same), is used a lot. And is going to be trickier to pull from the URL since we'll have to make sure we verify all the various rules for how they convert an id to a path. I know that information is out there, but this is low-priority for now.

jechols commented 2 years ago

This is actually not that tough to do, but it may not be very useful... to test this locally we have to create a copy of the existing package, which is tough to deal with - it gets things out of sync, you edit the wrong files, etc.

Furthermore, you can't upload the UO view package to the UOtest view - it complains that the folder name is incorrect.

The only way to handle this in a semi-nice way (that I can think of) involves doing some weird hackery: we build something that changes how the package compilation works. We'd have to have it do a recursive copy, zip up files from the copied view folder, then destroy the copy. I don't know if it's worth it.

I'm going to keep the code in that gets view data from the URL just in case, but it's not really going to be useful at the moment.