search

uoregon-libraries / uolib-primo-nui

University of Oregon Libraries implementation of the Primo New UI
0 stars 0 forks source link

Fix collapsable facets #50

Closed jechols closed 2 years ago

jechols commented 2 years ago

We had code that did this and it worked, but then I tinkered with the "external results" facet and now everything is broken.

I'll have to do some more testing, but it seems like the external results facet work fine on the current deploy (I believe what I deployed last is from commit bf33590). Something since then broke external results, hence the tinkering. If I can isolate and fix whatever broke things, then all this works again I think.

jechols commented 2 years ago

I ended up reverting various changes to get it working more or less how it works today. This uses code that is a modified version of non-VE external results, which was implemented something like four years ago. I don't know if this will cause problems in the future, but at the moment it's the only thing that seems to work.

Note that it doesn't work all the time. I'm seeing intermittent oddities. I checked production and I see the same intermittent problems (external search just never gets injected sometimes), so I'm not going to spend any more time here.