search

uoregon-libraries / uolib-primo-nui

University of Oregon Libraries implementation of the Primo New UI
0 stars 0 forks source link

VE: Frame for "Send to" incomplete #53

Closed MargaretA-UO closed 2 years ago

MargaretA-UO commented 2 years ago

The upper left bracket graphic is missing in the Send To section in VE: image

MargaretA-UO commented 2 years ago

Checking Primo classic, it's also missing there.
It just looks sloppy. Not huge priority, of course.

jechols commented 2 years ago

This is an odd one. It looks like something we customized at some point, though I have no idea why we made the shadow the way we did. I could remove it entirely, but I don't know if I can fix it. I'll give it a bit more effort and let you know.

jechols commented 2 years ago

If you don't mind dropping that shadow entirely, I think that's actually the best option. Some of the other customizations in the same CSS appear to break accessibility in odd little ways, and the rules aren't very well explained. I suspect these are rules somebody created to fix a problem that's either no longer present, or which wasn't able to be fully fixed anyway.

Here's what it looks like without the shadow:

image

As an added bonus, dropping these CSS rules fixes the "Related Items" box to have next and previous buttons:

Old:

image

New:

image

MargaretA-UO commented 2 years ago

Ooh! Hurray for unintended consequences. Sounds like the right solution. Thanks!

From: Jeremy Echols @.> Sent: Wednesday, June 29, 2022 12:20 PM To: uoregon-libraries/uolib-primo-nui @.> Cc: Margaret Alexander @.>; Author @.> Subject: Re: [uoregon-libraries/uolib-primo-nui] VE: Frame for "Send to" incomplete (Issue #53)

If you don't mind dropping that shadow entirely, I think that's actually the best option. Some of the other customizations in the same CSS appear to break accessibility in odd little ways, and the rules aren't very well explained. I suspect these are rules somebody created to fix a problem that's either no longer present, or which wasn't able to be fully fixed anyway.

Here's what it looks like without the shadow:

[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/2157974/176518281-46c74709-e9ce-4061-ab32-e379c676efb1.png__;!!C5qS4YX3!CKUE2xufImAGOpOgtOv4yNFFeNJhoSb_6AA_HkBX620norrf6OEFrQZWTowPfMHFKZ16MPOoHgSxTkUqP6ro7_rhekDu$

As an added bonus, dropping these CSS rules fixes the "Related Items" box to have next and previous buttons:

Old:

[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/2157974/176518464-140fc134-af50-483c-8822-3cfdbda7a44a.png__;!!C5qS4YX3!CKUE2xufImAGOpOgtOv4yNFFeNJhoSb_6AA_HkBX620norrf6OEFrQZWTowPfMHFKZ16MPOoHgSxTkUqP6ro7-wdcCJa$

New:

[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/2157974/176518491-1661fa4d-7eed-4782-8421-ccfa411083b9.png__;!!C5qS4YX3!CKUE2xufImAGOpOgtOv4yNFFeNJhoSb_6AA_HkBX620norrf6OEFrQZWTowPfMHFKZ16MPOoHgSxTkUqP6ro71kYIEPC$

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/uoregon-libraries/uolib-primo-nui/issues/53*issuecomment-1170394809__;Iw!!C5qS4YX3!CKUE2xufImAGOpOgtOv4yNFFeNJhoSb_6AA_HkBX620norrf6OEFrQZWTowPfMHFKZ16MPOoHgSxTkUqP6ro7wDb-mGp$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ASE4BQFGS3IONYBWUYTA6Q3VRSOWXANCNFSM5SNPQQKA__;!!C5qS4YX3!CKUE2xufImAGOpOgtOv4yNFFeNJhoSb_6AA_HkBX620norrf6OEFrQZWTowPfMHFKZ16MPOoHgSxTkUqP6ro71dMLY70$. You are receiving this because you authored the thread.Message ID: @.**@.>>

jechols commented 2 years ago

This is live and ready for QA, @MargaretA-UO

MargaretA-UO commented 2 years ago

Looks good.