libtiff-dev and is missing from package.xml for noetic

uos / lvr2

Las Vegas Reconstruction 2.0

BSD 3-Clause "New" or "Revised" License

104 stars 18 forks source link

libtiff-dev and is missing from package.xml for noetic #21

Open kjeremy opened 2 months ago

amock commented 1 month ago

Indeed libtiff-dev is missing (fixed with PR #22 ). However, lz4 seems to be already existing in all branches. @kjeremy , could you specify the exact branch/tag/commit you are using?

kjeremy commented 1 month ago

Thanks for fixing this with libtiff-dev!

Looking back on this I think I misspoke with lz4. It does appear to be specified correctly. I had to modify the build logic for nixos so that the package could find lz4: https://github.com/lopsided98/nix-ros-overlay/pull/458/commits/2de811f0881e7718219efa803a3957e88439e7e5 and that's probably when I thought the package wasn't specified.