sets dependencies and linking in the library

uos / sick_tim

A ROS driver for the SICK TiM series of laser scanners.

http://wiki.ros.org/sick_tim

47 stars 90 forks source link

sets dependencies and linking in the library #12

Closed efernandez closed 10 years ago

efernandez commented 10 years ago

It was actually broken (detected on other machine) because the library didn't have the _gencfg dependency. Now works and the dependencies are factorized.

Sorry for the "noise".

mintar commented 10 years ago

Could you shortly elaborate a bit what exactly was broken? The sick_tim3xx_datagram_test worked before.

Just curious, I think I'll merge your pull request anyway since it's better factorized.

efernandez commented 10 years ago

Yes, I created a library in the project (sick -> libsick.so), but I didn't put the dependency on the _gencfg:

add_dependencies(sick ${PROJECT_NAME}_gencfg)

The dependency was only for the executables, but that's not enough, so it can fail to compile the library itself.

mintar commented 10 years ago

Thanks!