search

uos / sick_tim

A ROS driver for the SICK TiM series of laser scanners.
http://wiki.ros.org/sick_tim
47 stars 90 forks source link

Parameterized the timeout variable #23

Closed jeff-o closed 9 years ago

jeff-o commented 9 years ago

For corner cases where the TIM and computer are powered at the same time, and the ROS node is launched before the TIM551 device is ready. Increase timelimit to avoid this condition.

Added a TCP-specific launch file.

NOTE: THESE CHANGES ARE UNTESTED ON A REAL DEVICE.

jspricke commented 9 years ago

Thanks for the pull request for #22. I would propose to loop the port initialization instead of increasing the timeout.

jeff-o commented 9 years ago

Okay, updated param as int instead of string. I also removed the TCP-specific launch file and placed the param inside of the default launch file.

jspricke commented 9 years ago

Thanks Jeff, I would be ok with merging this after squashing the commits.

mintar commented 9 years ago

LGTM.

jspricke commented 9 years ago

Hi Jeff, could you please squash your commits and force push them, so we can merge this? Thanks!

jspricke commented 9 years ago

Hi Jeff, sorry for the late reply (btw. it's good practice to write a comment here, once you are done with working on the branch). Can you please fix your commit message to only state what you really change and do a git push -f to get rid of the merges? Thanks!

jspricke commented 9 years ago

I've pushed a cleaned up version of this.

jeff-o commented 9 years ago

Thanks, Jochen.

On Mon, Mar 30, 2015 at 12:07 PM, Jochen Sprickerhof < notifications@github.com> wrote:

Closed #23 https://github.com/uos/sick_tim/pull/23.

— Reply to this email directly or view it on GitHub https://github.com/uos/sick_tim/pull/23#event-268647159.

Jeff Schmidt System Integration Technologist Clearpath Robotics Phone: 519-513-2416