search

uos / sick_tim

A ROS driver for the SICK TiM series of laser scanners.
http://wiki.ros.org/sick_tim
47 stars 90 forks source link

add ros params to override a few values #24

Closed mikeferguson closed 9 years ago

mikeferguson commented 9 years ago

These are required for easily interacting with a particular version of TIM561 that we are using.

mikeferguson commented 9 years ago

@jspricke Thanks for the merge -- can we get a new indigo debian release too?

mintar commented 9 years ago

Hi @mikeferguson , thanks for your PR! I was going to do a new release anyway tomorrow, I just wanted to wait until after the latest sync (since they asked us not to do new feature releases until after that). Could you add a new launch file with the proper params for the TiM561 first?

mikeferguson commented 9 years ago

@mintar -- I can't actually add a launch file quite yet -- we're using these lasers in house, but I don't yet have a final part number and the launch file would give away some of the unannounced specifications -- I will certainly circle back with a launch file later on, but getting these changes into debs will make deploying to robots easier in the interim.

mintar commented 9 years ago

Ah, I see. We don't have a 561 ourselves, but I was contacted a couple of weeks ago by people who own the TiM561-2050101 (i.e. the final released version), and they sent me a bagfile of the datagram topic. So I just went back and checked, and indeed the measurement frequency reported by the device is incorrect; it's one third of what the TiM310 reports, but should be three times that. I've added a warning to that effect in cf3e6ce5. Perhaps somebody should tell SICK?

I'll do the release after lunch.

mikeferguson commented 9 years ago

SICK has already been made aware of the measurement frequency issue.

mintar commented 9 years ago

Done: https://github.com/ros/rosdistro/pull/7528

mikeferguson commented 9 years ago

Thanks!