uos / sick_tim

A ROS driver for the SICK TiM series of laser scanners.
http://wiki.ros.org/sick_tim
47 stars 90 forks source link

Update package.xml #26

Closed jeff-o closed 9 years ago

jeff-o commented 9 years ago

Change the dependency to libusb-1.0. This change allows the package to build in Ubuntu 14.04 / ROS Indigo.

mintar commented 9 years ago

Hi Jeff, the package builds in 14.04/indigo without that change. What error are you getting?

jspricke commented 9 years ago

According to https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L2237, the current version should be fine.

jeff-o commented 9 years ago

Here's the error:

[ 17%] [ 17%] Building CXX object sick_tim/CMakeFiles/sick_tim_3xx.dir/src/sick_tim_common_usb.cpp.o

Building CXX object sick_tim/CMakeFiles/sick_tim_3xx.dir/src/sick_tim_common_mockup.cpp.o

In file included from /home/administrator/sensors_ws/src/sick_tim/src/sick_tim_common_usb.cpp:39:0:

/home/administrator/sensors_ws/src/sick_tim/include/sick_tim/sick_tim_common_usb.h:45:20: fatal error: libusb.h: No such file or directory

include

                ^

compilation terminated.

In file included from /home/administrator/sensors_ws/src/sick_tim/src/sick_tim_common_mockup.cpp:36:0:

/home/administrator/sensors_ws/src/sick_tim/include/sick_tim/sick_tim_common_mockup.h:42:20: fatal error: libusb.h: No such file or directory

include

                ^

compilation terminated.

On Thu, May 14, 2015 at 5:41 PM, Jochen Sprickerhof < notifications@github.com> wrote:

According to https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L2237, the current version should be fine.

— Reply to this email directly or view it on GitHub https://github.com/uos/sick_tim/pull/26#issuecomment-102178074.

Jeff Schmidt System Integration Technologist Clearpath Robotics Phone: 519-513-2416

jspricke commented 9 years ago

Sounds like an error somewhere else: http://packages.ubuntu.com/search?searchon=contents&keywords=libusb.h&mode=exactfilename&suite=trusty&arch=any

mintar commented 9 years ago

I agree, it must be something on your system. On the build farm and all our PCs, the current version builds just fine: http://jenkins.ros.org/view/IbinT64/job/ros-indigo-sick-tim_binarydeb_trusty_amd64/

Also, the build-depends in package.xml shouldn't have any influence on libusb, since it's not a ROS package. It is found directly in the CMakeLists.txt, so if it's installed, it should be found no matter if the package.xml build-depends on it or not.

Unless you have something crazy like a ROS package that's called libusb-1.0[-dev], which would cause conflicts.

In any case, the problem is something specific to your installation, the package is just fine. Perhaps you should set up a fresh catkin workspace with only sick_tim in it and then gradually add the rest of your current worspace until you see what breaks it.

jeff-o commented 9 years ago

OK, I'll check if there are any conflicts. Sorry for causing trouble!

mintar commented 9 years ago

No trouble at all! :)