search

uos / sick_tim

A ROS driver for the SICK TiM series of laser scanners.
http://wiki.ros.org/sick_tim
47 stars 90 forks source link

Add min/max angle arguments to URDF macro #60

Closed jacobperron closed 6 years ago

jacobperron commented 6 years ago

This is useful for setting the FOV in simulation (which can already be done for the real sensor).

mintar commented 6 years ago

Thanks for your PR! The tests above have failed. The error message is: Undefined parameters [min_angle,max_angle]. I don't see at a glance where the error is. Could you check and push a fix?

I'll be on vacation next week, but will check + merge the week after.

jacobperron commented 6 years ago

The change was missing from the tim310 macro. Rebased and updated the commit message.

mintar commented 6 years ago

Great, thanks!