uosis / laminar-web-components

Web Component definitions for Laminar
MIT License
37 stars 8 forks source link

Upgrade laminar to 0.13.0 version #14

Closed mprevel closed 3 years ago

mprevel commented 3 years ago

Hi,

I was really happy to find this repository providing ready components. Nonetheless, I encountered some issues when trying to use the component themes and this is due to an update of the laminar API I am using. So this PR updates the laminar version to the current one.

This PR updates Laminar version to 0.12.2 It fixes the ReactiveStyle Style signature that has been updated. It also updates sbt-scalajs to support this laminar version, and scalajs bundler accordingly.

The project version has not been changed and to ensure an easy use (without conflicts) should probably be set according to the laminar minor version.

The build itself should probably be updated to be standardized (it is currently hard to contribute) :

Regards,

raquo commented 3 years ago

@mprevel Thanks!

Sorry for the inconvenient timing, but could you please bump Laminar version in this PR to 0.13.0? Just released.

mprevel commented 3 years ago

@raquo I'll check that tonight :)

mprevel commented 3 years ago

Laminar version updated to 0.13.0

silizza commented 3 years ago

Hi! Thank you for your job!

Are there any plans to merge this pull request and when?