search

up-for-grabs / up-for-grabs.net

This is a list of projects which have curated tasks specifically for new contributors. These issues are a great way to get started with a project, or to help share the load of working on open source projects. Jump in!
https://up-for-grabs.net/
Other
5.31k stars 2.02k forks source link

Accessibility: For some odd reason screenreaders don't see the list of projects #2768

Open zersiax opened 3 years ago

zersiax commented 3 years ago

Just had a super quick look at this page and something odd appears to be happening. The entire projects section between the " Projects" h1 and the "I want to get involved" h1 is just completely invisible for screenreader users. I see the elements in the DOM tree, but something is making the screenreader think that part is not actually part of the DOM. The usual suspect is an errand aria-hidden somewhere, which I didn't immediately see in the code, or a display: none that can only be removed by clicking an icon that isn't visible to screenreader users. I didn't immediately see that either, not on the entire div that is. Any clue what might be happening here? Is the project list collapsed by default, visually speaking? (can't check, blind developer myself :) )

genderplugin commented 3 years ago

Hi!

I am using the NVDA screenreader and everything seems to still be working fine. Is this still an issue for you?

zersiax commented 3 years ago

Hmm. No, or well ...not in Firefox, but yes in Chrome and Edge, where I have adblockers running. I see an error in the console abou google analytics erroring out, might that be why?

ritwik12 commented 3 years ago

@zersiax Did you tried without Adblockers? This should not be an issue as we are not serving ads. Maybe your ad blocker is blocking even google analytics.

ritwik12 commented 3 years ago

visually speaking? (can't check, blind developer myself :) )

@zersiax I am really impressed to see that you are contributing to Open Source. if you are a beginner or need any help. Feel free to pop a mail to me anytime. Would be happy to help :)

zersiax commented 3 years ago

Looks like tracker_prevention settings in the browser are blocking Google Analytics ...which makes sense, given GA is a tracker :) Might be that GA is in the minified JS before the list of filters gets loaded, that would probably cause this behavior :)

ritwik12 commented 3 years ago

@zersiax Thanks for taking a look. From what I can see in _includes/scripts.html at https://github.com/up-for-grabs/up-for-grabs.net/blob/gh-pages/_includes/scripts.html. The GA is mentioned at the last only.

genderplugin commented 3 years ago

@ritwik12 sorry to hop on but could I send you an email as well? having trouble finding a good first issue to tackle and would love some tips.

ritwik12 commented 3 years ago

@ethanstarcher Sure, I was thinking of taking your name also. Please let me know if I can help you.

mervy93 commented 1 year ago

[Uploading macOSServer57_compressed.pdf…]()