Fix problem saving resource evicted from Chrome memory cache

up209d / ResourcesSaverExt

Chrome Extension for one click downloading all resources files and keeping folder structures.

GNU General Public License v3.0

1.65k stars 337 forks source link

Fix problem saving resource evicted from Chrome memory cache #24

Closed ccinelli closed 5 years ago

ccinelli commented 5 years ago

This saves the content as soon the request end because it may not available later. See https://groups.google.com/forum/#!topic/google-chrome-developer-tools/nQ4aVoKSsLE

up209d commented 5 years ago

One feature is not working for your specific case doesn't mean the extension is suck. It lack of testing and there is no reason to rate it 2 stars without leaving a chance for a developer to fix it. For the type of people like you, I don't need your contribution.

ccinelli commented 5 years ago

I will change my review when it is fixed ;-) And as you can see here, I am willing to work with the current code. Just a quick suggestion: you do not need to leave commented code that look pretty messy. Git saves all the old version of the code.

This PR fix the problem for me. Otherwise it saves all XHR requests with "No content: ...". I would have prefer to Download the resources immediately but it was taking too long and without tests, I was afraid of breaking things.