up209d / ResourcesSaverExt

Chrome Extension for one click downloading all resources files and keeping folder structures.
GNU General Public License v3.0
1.65k stars 337 forks source link

Not all resources are downloaded from the current tab. #25

Closed MaheshBaisani closed 5 years ago

MaheshBaisani commented 5 years ago

HI,

First of all thank you for providing a great tool.. When click on Save all resources button it downloads all the resources files of all domain from the current tab except few domains like ng://, webpack:// which are will available some times for angular/reactJS app. resourcewebpackerror [](url) Please find the above screenshot for your reference where all tick marked resources are downloaded and "X" marked contents are not able to downloaded.

Please kindly check and do needful.

up209d commented 5 years ago

@MaheshBaisani I believe it won't skip webpack and ng protocol but stripped down everything before ://, I did test it before, are you using the 0.1.6 version atm?

Screen Shot 2019-06-02 at 3 10 26 pm
MaheshBaisani commented 5 years ago

@up209d , Thank you for your quick reply. Yes i am using latest version 0.1.6 only. Capture , Now also i tried with some online example from below link (I run the index.html file and it contains the webpack files.) but still no luck. I am not able to get the webpack content. https://github.com/Booyanach/here-map/tree/master/docs

58757083-9bd3cf80-8548-11e9-9ec1-71103c67d858

up209d commented 5 years ago

@MaheshBaisani I found the problem, just fixed and pushed, can you use the unpacked version in this repo to test, instead of the official one on Chrome Webstore?

MaheshBaisani commented 5 years ago

Kudos! @up209d for your great work. As you suggested I checked with unpacked version and Its working as expected. Thank you so much for your prompt response and fixes.

You can do one more round of testing and push to Chrome Webstore.

Once again thanks for your support

up209d commented 5 years ago

@MaheshBaisani Cheers mate, thank you for pointing out the issue. I gonna update to Webstore tomorrow.